-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flatlist instead of flashlist #42513
Conversation
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@MelvinBot recheck |
code looks good, start to test now |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-05-24.at.11.39.07.movAndroid: mWeb ChromeScreen.Recording.2024-05-24.at.11.39.59.moviOS: NativeScreen.Recording.2024-05-24.at.11.39.29.moviOS: mWeb SafariScreen.Recording.2024-05-24.at.11.40.06.movMacOS: Chrome / Safariweb-resize.mp4MacOS: DesktopScreen.Recording.2024-05-24.at.11.41.34.mov |
@jp928 Pls add one more step: Verify that the item is selected and the suggestion list is closed For Offline tests and QA steps sections: put the simple text: Same as above |
@jp928 Pls add the videos for all platforms |
@dukenv0307 All platform videos had been updated. |
looks good and tests well |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.77-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
Details
Fixed Issues
$ #40508
PROPOSAL: $ #40508 (comment)
Tests
@
to mention someone.Offline tests
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen_recording_20240524_150726.webm
Android: mWeb Chrome
SVID_20240524_162839_1.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-23.at.19.24.30.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-24.at.16.05.54.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-05-24.at.3.54.07.PM.mov
MacOS: Desktop
Screen.Recording.2024-05-24.at.9.35.58.PM.mov
I have read the CLA Document and I hereby sign the CLA